RFR: 8313633: [macOS] java/awt/dnd/NextDropActionTest/NextDropActionTest.java fails with java.lang.RuntimeException: wrong next drop action!

Wed Aug 9 23:01:28 UTC 2023

On Wed, 9 Aug 2023 21:59:23 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Test fails intermittently on macosx-aarch64. Adding a delay between the first and second drag fixes the issue since there may be some timing issue between the two drag events. Tested the change twice, with 100 repeats per test on all OS's. All tests passed. Also corrected a spelling mistake and added logical newlines to read/debug cleaner.

Test changes and CI Testing looks good.

@DamonGuy Suggestion: You can replace the nested ternary compare on Ln#178 (`n < 0 ? -1 : n == 0 ? 0 : 1`) with `Integer.compare(n,0)`. Looks compact & clean to use Integer.compare here.

-------------

Marked as reviewed by honkar (Committer).

PR Review: https://git.openjdk.org/jdk/pull/15213#pullrequestreview-1570737986