RFR: 8294535 : Add screen capture functionality to PassFailJFrame [v3]

Harshitha Onkar honkar at openjdk.org
Wed Aug 9 23:46:28 UTC 2023


On Wed, 9 Aug 2023 20:55:32 GMT, lawrence.andrews <duke at openjdk.org> wrote:

>> 1) Used builder pattern 
>> 2) Tested AWT tests and it passed
>
> lawrence.andrews has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Changed enableScreenCapture method name to screenCapture shorter method name
>  - Update full name

Changes requested by honkar (Committer).

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 609:

> 607: 
> 608:         public Builder screenCapture() {
> 609:             this.screenCapture = true;

> Its better to keep method name and var name separately.

@lawrence-andrew You need to revert the variable name here then.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14094#pullrequestreview-1570772855
PR Review Comment: https://git.openjdk.org/jdk/pull/14094#discussion_r1289360566



More information about the client-libs-dev mailing list