RFR: 8139208: [macosx] Issue with setExtendedState of JFrame [v2]

Damon Nguyen dnguyen at openjdk.org
Fri Aug 11 14:11:29 UTC 2023


On Thu, 10 Aug 2023 23:51:29 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Swapped order of showing frame and managing extended frame state.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed debug statements

I didn't see in the file history where this ordering was switched. It looks like this was a regression. Any idea what caused it?

src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line 674:

> 672:                 /* Frame or Dialog should be set property WINDOW_FULLSCREENABLE to true if the
> 673:                 Frame or Dialog is resizable.
> 674:                 **/

Any reason for `**/` vs `*/`?

-------------

PR Review: https://git.openjdk.org/jdk/pull/15236#pullrequestreview-1573706522
PR Review Comment: https://git.openjdk.org/jdk/pull/15236#discussion_r1291363213


More information about the client-libs-dev mailing list