client-libs-dev Digest, Vol 26, Issue 20
George Wangari
georgewangari44 at gmail.com
Fri Aug 11 16:38:08 UTC 2023
Hello
On 8/2/23, client-libs-dev-request at openjdk.org
<client-libs-dev-request at openjdk.org> wrote:
> Send client-libs-dev mailing list submissions to
> client-libs-dev at openjdk.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> https://mail.openjdk.org/mailman/listinfo/client-libs-dev
> or, via email, send a message with subject or body 'help' to
> client-libs-dev-request at openjdk.org
>
> You can reach the person managing the list at
> client-libs-dev-owner at openjdk.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of client-libs-dev digest..."
>
>
> Today's Topics:
>
> 1. Re: RFR: 8311031: JTable header border vertical lines are not
> aligned with data grid lines [v14] (Tejesh R)
> 2. Re: RFR: 8311031: JTable header border vertical lines are not
> aligned with data grid lines [v13] (Alexey Ivanov)
> 3. Re: RFR: 8311031: JTable header border vertical lines are not
> aligned with data grid lines [v14] (Alexey Ivanov)
> 4. Re: RFR: JDK-8311938: Add default cups include location for
> configure on AIX [v3] (Christoph Langer)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Wed, 2 Aug 2023 16:28:08 GMT
> From: Tejesh R <tr at openjdk.org>
> To: <client-libs-dev at openjdk.org>
> Subject: Re: RFR: 8311031: JTable header border vertical lines are not
> aligned with data grid lines [v14]
> Message-ID:
> <hnpmDDAnacpoKptffZYwgLBJoZqNa47cXJ6QN1uPqeI=.2883e104-0db6-4acd-8e05-04c4a2f6b8aa at github.com>
>
> Content-Type: text/plain; charset=utf-8
>
>> The header border uses `g.drawLine` whereas the JTable data grid lines
>> uses `SwingUtilities2.drawVLine` and `SwingUtilities2.drawHLine` to draw
>> horizontal and vertical lines. The SwingUtilities2 uses
>> `Graphics.fillRect` which contributes to the difference between the
>> position of these two lines which happens/visible at higher ui scaling
>> (difference in alignment between vertical lines of these two). The fix
>> propose to use the same methods for metal L&F of JTable header border
>> paint.
>> CI testing shows green.
>>
>> 
>
> Tejesh R has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Review fix
> - Review fix
>
> -------------
>
> Changes:
> - all: https://git.openjdk.org/jdk/pull/14766/files
> - new: https://git.openjdk.org/jdk/pull/14766/files/106de984..be04454f
>
> Webrevs:
> - full: https://webrevs.openjdk.org/?repo=jdk&pr=14766&range=13
> - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14766&range=12-13
>
> Stats: 16 lines in 1 file changed: 1 ins; 12 del; 3 mod
> Patch: https://git.openjdk.org/jdk/pull/14766.diff
> Fetch: git fetch https://git.openjdk.org/jdk.git
> pull/14766/head:pull/14766
>
> PR: https://git.openjdk.org/jdk/pull/14766
>
>
> ------------------------------
>
> Message: 2
> Date: Wed, 2 Aug 2023 16:28:09 GMT
> From: Alexey Ivanov <aivanov at openjdk.org>
> To: <client-libs-dev at openjdk.org>
> Subject: Re: RFR: 8311031: JTable header border vertical lines are not
> aligned with data grid lines [v13]
> Message-ID:
> <1ByQ1X2JsCe9GQAsAeQd0MdYWTbwF60A9dj-8bgslYM=.c24f0062-248e-4c44-8c23-8be2c487e84d at github.com>
>
> Content-Type: text/plain; charset=utf-8
>
> On Wed, 2 Aug 2023 08:55:19 GMT, Tejesh R <tr at openjdk.org> wrote:
>
>>> The header border uses `g.drawLine` whereas the JTable data grid lines
>>> uses `SwingUtilities2.drawVLine` and `SwingUtilities2.drawHLine` to draw
>>> horizontal and vertical lines. The SwingUtilities2 uses
>>> `Graphics.fillRect` which contributes to the difference between the
>>> position of these two lines which happens/visible at higher ui scaling
>>> (difference in alignment between vertical lines of these two). The fix
>>> propose to use the same methods for metal L&F of JTable header border
>>> paint.
>>> CI testing shows green.
>>>
>>> 
>>
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix
>
> Changes requested by aivanov (Reviewer).
>
> I'll post [this
> comment](https://github.com/openjdk/jdk/pull/14464#pullrequestreview-1558834675)
> here too:
>
>> I still prefer the previous version where the exception was thrown
>> directly.
>>
>> In fact, you don't create real UI, the test doesn't depend on processing
>> events ? the entire test can be run on main thread *safely*. Get rid of
>> `invokeAndWait` altogether?
>
> -------------
>
> PR Review:
> https://git.openjdk.org/jdk/pull/14766#pullrequestreview-1558832421
> PR Comment: https://git.openjdk.org/jdk/pull/14766#issuecomment-1662525912
>
>
> ------------------------------
>
> Message: 3
> Date: Wed, 2 Aug 2023 16:37:58 GMT
> From: Alexey Ivanov <aivanov at openjdk.org>
> To: <client-libs-dev at openjdk.org>
> Subject: Re: RFR: 8311031: JTable header border vertical lines are not
> aligned with data grid lines [v14]
> Message-ID:
> <TYgBhTR5jgTTcOfddtlXcrkoKzWVa-O-HOeagrgd114=.11bd6a43-bf46-4f7d-b0f6-021efa6f1d7e at github.com>
>
> Content-Type: text/plain; charset=utf-8
>
> On Wed, 2 Aug 2023 16:28:08 GMT, Tejesh R <tr at openjdk.org> wrote:
>
>>> The header border uses `g.drawLine` whereas the JTable data grid lines
>>> uses `SwingUtilities2.drawVLine` and `SwingUtilities2.drawHLine` to draw
>>> horizontal and vertical lines. The SwingUtilities2 uses
>>> `Graphics.fillRect` which contributes to the difference between the
>>> position of these two lines which happens/visible at higher ui scaling
>>> (difference in alignment between vertical lines of these two). The fix
>>> propose to use the same methods for metal L&F of JTable header border
>>> paint.
>>> CI testing shows green.
>>>
>>> 
>>
>> Tejesh R has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Review fix
>> - Review fix
>
> Marked as reviewed by aivanov (Reviewer).
>
> -------------
>
> PR Review:
> https://git.openjdk.org/jdk/pull/14766#pullrequestreview-1559428593
>
>
> ------------------------------
>
> Message: 4
> Date: Wed, 2 Aug 2023 16:48:43 GMT
> From: Christoph Langer <clanger at openjdk.org>
> To: <build-dev at openjdk.org>, <client-libs-dev at openjdk.org>
> Subject: Re: RFR: JDK-8311938: Add default cups include location for
> configure on AIX [v3]
> Message-ID:
> <vOkXQzDDJx_rjhiBoa9ABQoEXh8iN8XiLCm8KMMw49Q=.8d1e5af6-b87d-443a-a1ef-f8ab1f490053 at github.com>
>
> Content-Type: text/plain; charset=utf-8
>
> On Wed, 2 Aug 2023 15:20:55 GMT, Andreas Steiner <duke at openjdk.org> wrote:
>
>>> Add the default include location(/opt/freeware/include/) for cups on AIX.
>>> With this set the additional configure parameter --with-cups-include can
>>> be removed, which was needed on AIX.
>>
>> Andreas Steiner has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> move AIX check to default location section
>
> Looks good. Maybe you should also set DEFAULT_CUPS=yes, although it doesn't
> seem to be used anywhere.
>
> -------------
>
> Marked as reviewed by clanger (Reviewer).
>
> PR Review:
> https://git.openjdk.org/jdk/pull/15100#pullrequestreview-1559452240
>
>
> End of client-libs-dev Digest, Vol 26, Issue 20
> ***********************************************
>
More information about the client-libs-dev
mailing list