RFR: 8313697: [XWayland][Screencast] consequent getPixelColor calls are slow [v2]

Alexander Zvegintsev azvegint at openjdk.org
Mon Aug 14 05:54:28 UTC 2023


On Fri, 11 Aug 2023 21:57:41 GMT, Phil Race <prr at openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - switch to java.util.Timer
>>  - Make multiple calls to doCleanup() safe
>
> src/java.desktop/unix/classes/sun/awt/screencast/ScreencastHelper.java line 31:
> 
>> 29: import sun.security.action.GetPropertyAction;
>> 30: 
>> 31: import javax.swing.Timer;
> 
> Is there a reason you can't use java.util.Timer ? 
> Ideally [*] AWT classes should not depend on Swing classes since already Swing classes depend on AWT classes .. 
> 
> [*] yes, I know we already have such dependencies but only for very good reasons.

Of course we can use java.util.Timer. Swing timer is just more convenient to use. Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15250#discussion_r1292982890


More information about the client-libs-dev mailing list