RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v3]

Sergey Bylokhov serb at openjdk.org
Wed Aug 16 19:25:12 UTC 2023


On Thu, 10 Aug 2023 04:04:58 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future. It can be done with some effort, given that the significantly stricter gcc can now compile an experimental Windows JDK as of 2023, and will serve to significantly cut down on monstrosities in ancient Windows code
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove negation in os_windows.cpp

Why initial patch was reverter using this comment: "unfortunately, did not prove to be as useful as expected"? What was the problem? What about the "pedantic" option which was added last time?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-1681152431


More information about the client-libs-dev mailing list