RFR: JDK-8314246: javax/swing/JToolBar/4529206/bug4529206.java fails intermittently on Linux [v2]

Harshitha Onkar honkar at openjdk.org
Wed Aug 16 23:52:48 UTC 2023


On Wed, 16 Aug 2023 22:48:19 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   AutoWaitForIdle
>
> test/jdk/javax/swing/JToolBar/4529206/bug4529206.java line 82:
> 
>> 80:             SwingUtilities.invokeAndWait(() -> test());
>> 81:             Robot robot = new Robot();
>> 82:             robot.waitForIdle();
> 
> Changes look good. Did you try using using setAutoWaitForIdle?

Oh, I didn't notice that `setAutoWaitForIdle()` was not used the first time. I have changed it. I think adding a small amount of delay after `makeToolbarFloat()` is good in addition to `setAutoWaitForIdle()` to stabilize the test on slower systems.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15316#discussion_r1296539403


More information about the client-libs-dev mailing list