RFR: 8302687 Implement interfaces and shared code for announcement feature [v5]

Phil Race prr at openjdk.org
Thu Aug 17 18:52:32 UTC 2023


On Tue, 16 May 2023 17:56:04 GMT, Artem Semenov <asemenov at openjdk.org> wrote:

>> This enhancement covers basic API and shared code that should be implemented for the Accessibility Announcement feature.
>> 
>> CSR [JDK-8304499](https://bugs.openjdk.org/browse/JDK-8304499 "bugs.openjdk.org")
>> 
>> @mrserb @prrace @azuev-java please review
>
> Artem Semenov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update

There's a really  tree of JBS issues related to this topic and I see a process problem.

The bug for this PR is https://bugs.openjdk.org/browse/JDK-8302687

But the CSR in this PR is listed as https://bugs.openjdk.org/browse/JDK-8304499
but that is actually the CSR for https://bugs.openjdk.org/browse/JDK-8302352
which is an umbrella bug.

So this is wrong.
The CSR must be the CSR for the bug in the PR, ie for something you will actually push!
Else skara and everyone else will get confused.

Then there's the overall question as to how important, or appropriate is this API ?
Seems like its not really an A11Y API, its an arbitrary text-to-speech API.
I think of the A11Y APIs as being tied to the UI and making it accessible, not
providing some other way of communicating something which isn't even in the UI.
Put it this way, if I am NOT using an AT to provide speech, how are you communicating
whatever it is to the user - something changes in the UI, right ?
So then the A11Y API will be able to report that already so why do you need this ?
Show me some equivalent cases and uses in platform ATs APIs

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13001#issuecomment-1682793726


More information about the client-libs-dev mailing list