RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v35]

[Phil Race]

On Thu, 17 Aug 2023 18:09:26 GMT, Phil Race <prr at openjdk.org> wrote:

>> ScientificWare has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   StyleSheet.java : Adds missing space in some if statements
>
> As mentioned earlier in this review, you need to absorb the changes in 
> https://github.com/openjdk/jdk/pull/10317/
> into THIS PR and withdraw 10317.

> @prrace
> 
> Do I absorb the changes in #15262 too ?

I hadn't even seen that one until you just mentioned it !
I was puzzled because it was 8 months old .. but I then realised you've had it in draft all that time and just made it RFR a few days ago.

Having a third concurrent PR making changes to the same file is making things nearly insane.

The formal answer to your question is that
(1) If these changes are unrelated in anyway to the other changes they can go separately, either before or after
(2) If these changes require that the other changes be pushed first then they can go EITHER in the same PR or after
(3)  if these changes are interdependent, meaning they cannot go before the other change and the other change also depends on them, then they should all be in one PR

If its (1) or (2) then I suggest we completely ignore this new PR until after the issues in the first one are pushed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/9825#issuecomment-1682807049