RFR: 6928542: Chinese characters in RTF are not decoded

Phil Race prr at openjdk.org
Thu Aug 17 21:38:32 UTC 2023


On Thu, 20 Apr 2023 05:47:35 GMT, Ichiroh Takiguchi <itakiguchi at openjdk.org> wrote:

> "character set of font" (font charset) table was created by "Rich Text Format Specification 1.9.1"
> https://interoperability.blob.core.windows.net/files/Archive_References/[MSFT-RTF].pdf
> It refers windgi.h
> https://learn.microsoft.com/en-us/windows/win32/api/wingdi/ns-wingdi-textmetrica
> 
> Test files and testcase are in bugid [JDK-6928542](https://bugs.openjdk.org/browse/JDK-6928542)
> 
> Additional change:
> Special character `\line` should `\n`
> 
> **Note:** Following GitHub actions were failed
> linux-x86 / test (jdk/tier1 part 1) was failed, it seems it was already reported
>> [JDK-8305875](https://bugs.openjdk.org/browse/JDK-8305875) Test TraceVirtualThreadLocals should be run with continuations only
> 
> windows-aarch64 / build (debug) was failed, but I have no idea...

src/java.desktop/share/classes/javax/swing/text/rtf/RTFReader.java line 173:

> 171: 
> 172: /* TODO: per-font font encodings ( \fcharset control word ) ? */
> 173: 

Umm, since you are doing it, you really should also delete the TODO comment

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13553#discussion_r1297775562


More information about the client-libs-dev mailing list