RFR: 8139208: [macosx] Issue with setExtendedState of JFrame [v3]

[Harshitha Onkar]

On Mon, 21 Aug 2023 16:54:00 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Swapped order of showing frame and managing extended frame state.
>
> Alisen Chung has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - test update
>  - added test, updated comment

Changes requested by honkar (Committer).

test/jdk/javax/swing/JFrame/MaximizeWindowTest.java line 46:

> 44: 
> 45:                 splitPane.setDividerLocation(1000);
> 46: 

Extra newline can be removed.

test/jdk/javax/swing/JFrame/MaximizeWindowTest.java line 49:

> 47:                 frame.setVisible(true);
> 48: 
> 49:                 robot.delay(1000);

@alisenchung Please test the reproducer again.`robot.delay()` needs to be outside `invokeAndWait()` call else the test passes in both cases - with previous code & proposed fix.

test/jdk/javax/swing/JFrame/MaximizeWindowTest.java line 51:

> 49:                 robot.delay(1000);
> 50:             }
> 51:         });

Frame needs to be disposed at the end.

-------------

PR Review: https://git.openjdk.org/jdk/pull/15236#pullrequestreview-1587561825
PR Review Comment: https://git.openjdk.org/jdk/pull/15236#discussion_r1300462036
PR Review Comment: https://git.openjdk.org/jdk/pull/15236#discussion_r1300455382
PR Review Comment: https://git.openjdk.org/jdk/pull/15236#discussion_r1300456141