RFR: 8139208: [macosx] Issue with setExtendedState of JFrame [v4]
Harshitha Onkar
honkar at openjdk.org
Mon Aug 21 18:25:32 UTC 2023
On Mon, 21 Aug 2023 18:17:49 GMT, Alisen Chung <achung at openjdk.org> wrote:
>> Swapped order of showing frame and managing extended frame state.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>
> test update
test/jdk/javax/swing/JFrame/MaximizeWindowTest.java line 31:
> 29: frame = new JFrame();
> 30: frame.setDefaultCloseOperation(EXIT_ON_CLOSE);
> 31: frame.setSize(200, 200);
can be replaced with `frame.setSize(ORIGINAL_SIZE)`
test/jdk/javax/swing/JFrame/MaximizeWindowTest.java line 40:
> 38: public void componentResized(ComponentEvent e) {
> 39: System.out.println("Component size: " + e.getComponent().getSize());
> 40: if (e.getComponent().getSize().equals(new Dimension(200, 200))) {
can be replaced with `e.getComponent().getSize().equals(ORIGINAL_SIZE)`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15236#discussion_r1300488381
PR Review Comment: https://git.openjdk.org/jdk/pull/15236#discussion_r1300494820
More information about the client-libs-dev
mailing list