RFR: 8258970: Disabled JPasswordField foreground color is wrong with GTK LAF [v2]
Tejesh R
tr at openjdk.org
Tue Aug 22 05:17:26 UTC 2023
On Mon, 21 Aug 2023 10:42:07 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> Disabled JPasswordField foreground color was not grayed out in GTK LAF.
>>
>> The foreground color in disabled state was close to black color (RGB 0,0,0) for password field which is not differentiable from enabled state foreground color.
>>
>> To fix for this problem, the widget type is changed to `TEXT_AREA `for disable password field which returns the foreground color as gray. Checked with Oracle linux as well and fix worked fine.
>>
>> An automated test case has been added and checked in CI, link is added in JBS. Test mentioned in JBS also works fine with the fix.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix extended for TextField, FormattedTextField, Spinner
Looks Good To Me.
-------------
Marked as reviewed by tr (Committer).
PR Review: https://git.openjdk.org/jdk/pull/15263#pullrequestreview-1588325435
More information about the client-libs-dev
mailing list