RFR: 8311922: [macOS] right-Option key fails to generate release event [v2]

Damon Nguyen dnguyen at openjdk.org
Tue Aug 29 17:17:47 UTC 2023


On Mon, 28 Aug 2023 22:09:26 GMT, Alisen Chung <achung at openjdk.org> wrote:

> why was the keycode wrong with the previous fix? and why do we need to manually set leftAltKeyPressed = YES? should this be done in a different part of the code?

I originally added back the code that was removed. There seemed to be 2 instances of NSAlternateKeyMask afterwards, so the key code value was incorrect. This must've been the case before the regression as well I'd assume. leftAltKeyPressed has been removed as well since it doesn't seem necessary to fix this particular issue.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15432#issuecomment-1697839743


More information about the client-libs-dev mailing list