RFR: 8311922: [macOS] right-Option key fails to generate release event [v2]

Damon Nguyen dnguyen at openjdk.org
Tue Aug 29 17:17:48 UTC 2023


On Tue, 29 Aug 2023 00:27:58 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove duplicate alt key mask. Add value to other mask.
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/AWTEvent.m line 294:
> 
>> 292:         //kCGSFlagsMaskAppleRightAlternateKey,
>> 293:         58,
>> 294:         61,
> 
> Looks like the only change required to make right option key working is adding in the rightKeyCode (61) here. I don't think it is required to revert changes related to`leftAltKeyPressed`.

This seems correct. I updated it to only include the key code. Re-ran my test and TestAltUpDown, and both passed still.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15432#discussion_r1309128489


More information about the client-libs-dev mailing list