RFR: 8312165: Fix typos in java.desktop Swing [v3]

Alexey Ivanov aivanov at openjdk.org
Wed Aug 30 16:16:24 UTC 2023


On Wed, 30 Aug 2023 14:09:20 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin/master' into fix_typos_java.desktop
>>  - 8312165: Fix typos in java.desktop Swing
>>    
>>    apply suggestions from review
>>  - 8312165: Fix typos in java.desktop Swing
>>    
>>    revert changes from non-swing parts to minimize count of files to review
>>  - [PATCH] Fix typos in java.desktop
>>  - [PATCH] Fix typos in java.desktop
>>    
>>    update copyrights
>>  - [PATCH] Fix typos in java.desktop
>
> src/java.desktop/share/classes/javax/swing/JLayeredPane.java line 558:
> 
>> 556:             if(curLayer == layer) {
>> 557:                 results[layerCount++] = getComponent(i);
>> 558:             /// Short circuit the counting when we have them all
> 
> You should revert this instance too.
> Suggestion:
> 
>             /// Short-circuit the counting when we have them all

Shall we drop the third slash too?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14847#discussion_r1310345925


More information about the client-libs-dev mailing list