RFR: 8312075: FileChooser.win32.newFolder is not updated when changing Locale [v5]

Tejesh R tr at openjdk.org
Thu Aug 31 15:33:03 UTC 2023


On Thu, 31 Aug 2023 14:10:39 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review fix
>
> test/jdk/javax/swing/JFileChooser/FileChooserNewFolderLocaleTest.java line 77:
> 
>> 75:                 System.out.println("Failed to delete file : " +
>> 76:                         newFolderEnglish.getName());
>> 77:             }
> 
> It's a bit on the overthinking side yet you use the same code for both `newFolderEnglish` and `newFolderFrench`. A helper method to remove the folder and to print an error message would eliminate the duplicate code.

Helper method meaning what I have done right?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15069#discussion_r1311818111


More information about the client-libs-dev mailing list