RFR: 8312075: FileChooser.win32.newFolder is not updated when changing Locale [v5]
Tejesh R
tr at openjdk.org
Thu Aug 31 16:02:06 UTC 2023
On Thu, 31 Aug 2023 15:41:15 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Helper method meaning what I have done right?
>
> Yes, a helper method which deletes a directory that you pass as a parameter and prints an error if it fails.
>
> Then removing the two directories is a matter of calling this method twice: for the English and French directory.
>
> You just got the condition wrong, it seems. The one you used previously looked correct.
The previous one had an issue when `newFolderEnglish` / `newFolderFrench` is null. The updated one is right.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15069#discussion_r1311856291
More information about the client-libs-dev
mailing list