RFR: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab [v2]

Alisen Chung achung at openjdk.org
Fri Dec 1 20:35:10 UTC 2023


On Wed, 29 Nov 2023 18:59:25 GMT, Phil Race <prr at openjdk.org> wrote:

>> test/jdk/java/awt/Window/Grab/GrabTest.java line 221:
>> 
>>> 219:         robot.delay(100);
>>> 220:         robot.mouseRelease(InputEvent.BUTTON1_MASK);
>>> 221:         Util.waitForIdle(robot);
>> 
>> Can be replaced with BUTTON1_DOWN_MASK.
>> 
>> Has the fix been tested on macOS 14 ?
>
> That (about macOS 14) is the important question. Why is it so unstable on macOS 14 but fine everywhere else ?
> 
> Also can't you use "setAutoDelay(100)" instead of adding all these one-off delays ?

The test passes on macOS 14

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16867#discussion_r1412547730


More information about the client-libs-dev mailing list