RFR: 5108458: JTable does not properly layout its content [v13]
Alexey Ivanov
aivanov at openjdk.org
Mon Dec 4 14:10:09 UTC 2023
On Sat, 2 Dec 2023 20:55:30 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:
>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review fix
>
> src/java.desktop/share/classes/javax/swing/JTable.java line 3016:
>
>> 3014: // adjust the x coordinate for this case.
>> 3015: final int columnWidth = cm.getColumn(column).getWidth();
>> 3016: if( !getComponentOrientation().isLeftToRight() ) {
>
> Suggestion:
>
> if (!getComponentOrientation().isLeftToRight()) {
@TejeshR13, @turbanoff I'd rather preserve the original style that you followed because it fits into the surrounding code even though it's different from the standard Java code conventions.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16374#discussion_r1413922936
More information about the client-libs-dev
mailing list