RFR: 8320443: [macos] Test java/awt/print/PrinterJob/PrinterDevice.java fails on macOS [v2]

Phil Race prr at openjdk.org
Mon Dec 4 23:31:48 UTC 2023


On Wed, 22 Nov 2023 07:49:07 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8320443
>
> src/java.desktop/share/classes/sun/print/RasterPrinterJob.java line 2096:
> 
>> 2094: 
>> 2095:     synchronized protected void setGraphicsConfigInfo(AffineTransform at,
>> 2096:                                             double pw, double ph) {
> 
> Let's use blessed modifiers order
> Suggestion:
> 
>     protected synchronized void setGraphicsConfigInfo(AffineTransform at,
>                                                       double pw, double ph) {

fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16773#discussion_r1414628370


More information about the client-libs-dev mailing list