RFR: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab [v2]

Alexander Zvegintsev azvegint at openjdk.org
Tue Dec 5 01:28:37 UTC 2023


On Tue, 5 Dec 2023 01:01:50 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - updated test
>>  - updated test
>
> test/jdk/java/awt/Window/Grab/GrabTest.java line 121:
> 
>> 119: 
>> 120:             f.setVisible(true);
>> 121:             w.setVisible(true);
> 
> Suggestion:
> 
>             f.setVisible(true);
>             w.setVisible(true);
>             robot.delay(500);
> 
> 
> Since it is unstable test, adding a delay here after the first set of frame & window are made visible might be good.

+1, but it should be outside of the invokeAndWait. And there are other setVisible calls.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16867#discussion_r1414720493


More information about the client-libs-dev mailing list