RFR: 8319938: com/sun/java/swing/plaf/gtk/TestFileChooserSingleDirectorySelection.java fails with "getSelectedFiles returned empty array for LAF: javax.swing.plaf.metal.MetalLookAndFeel" [v3]
Abhishek Kumar
abhiscxk at openjdk.org
Tue Dec 5 12:18:05 UTC 2023
On Mon, 4 Dec 2023 20:53:51 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> test/jdk/com/sun/java/swing/plaf/gtk/TestFileChooserSingleDirectorySelection.java line 143:
>>
>>> 141: createAndShowUI();
>>> 142: fileChooser.setCurrentDirectory(testDir);
>>> 143: });
>>
>> `fileChooser.setFileSelectionMode` that you call below should be called on EDT, I suggest moving it into this block.
>>
>> This applies to all `check-*` methods.
>
> To eliminate duplicating code for disposing of the frame, create a helper method and call it from the `finally` block.
> `fileChooser.setFileSelectionMode` that you call below should be called on EDT, I suggest moving it into this block.
>
> This applies to all `check-*` methods.
Accessed on EDT.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16674#discussion_r1415503095
More information about the client-libs-dev
mailing list