RFR: 8319938: TestFileChooserSingleDirectorySelection.java fails with "getSelectedFiles returned empty array" [v5]

Alexey Ivanov aivanov at openjdk.org
Tue Dec 5 19:02:40 UTC 2023


On Tue, 5 Dec 2023 18:34:52 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`. For `DIRECTORIES_ONLY `mode, there may not be any directories in home directory and due to that test failed. Added the code to create temporary directories and files for the test.
>> Tested the current change on the machine it failed for multiple times, no failure observed.
>> CI link attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Access on EDT and few changes

`ActionEvent` and `ActionListener` aren't used any more, remove them, please.

Could you also update the copyright year in the file?

test/jdk/com/sun/java/swing/plaf/gtk/TestFileChooserSingleDirectorySelection.java line 210:

> 208:     private static void checkResult(UIManager.LookAndFeelInfo laf) throws Exception {
> 209:         SwingUtilities.invokeAndWait(() -> {
> 210:             File files[] = fileChooser.getSelectedFiles();

Suggestion:

            File[] files = fileChooser.getSelectedFiles();

Let's use Java-style array declaration.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16674#pullrequestreview-1765897404
PR Review Comment: https://git.openjdk.org/jdk/pull/16674#discussion_r1416152081


More information about the client-libs-dev mailing list