RFR: 8319938: TestFileChooserSingleDirectorySelection.java fails with "getSelectedFiles returned empty array" [v7]

Tejesh R tr at openjdk.org
Wed Dec 6 05:20:40 UTC 2023


On Tue, 5 Dec 2023 19:35:50 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`. For `DIRECTORIES_ONLY `mode, there may not be any directories in home directory and due to that test failed. Added the code to create temporary directories and files for the test.
>> Tested the current change on the machine it failed for multiple times, no failure observed.
>> CI link attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Copyright year update

test/jdk/com/sun/java/swing/plaf/gtk/TestFileChooserSingleDirectorySelection.java line 206:

> 204:     }
> 205: 
> 206:     private static void checkResult(UIManager.LookAndFeelInfo laf) throws Exception {

Instead of passing the laf through all the methods, can't we create and use a class variable?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16674#discussion_r1416677619


More information about the client-libs-dev mailing list