RFR: 8319938: TestFileChooserSingleDirectorySelection.java fails with "getSelectedFiles returned empty array" [v7]
Tejesh R
tr at openjdk.org
Wed Dec 6 13:21:42 UTC 2023
On Wed, 6 Dec 2023 10:55:33 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> test/jdk/com/sun/java/swing/plaf/gtk/TestFileChooserSingleDirectorySelection.java line 206:
>>
>>> 204: }
>>> 205:
>>> 206: private static void checkResult(UIManager.LookAndFeelInfo laf) throws Exception {
>>
>> Instead of passing the laf through all the methods, can't we create and use a class variable?
>
>> Instead of passing the laf through all the methods, can't we create and use a class variable?
>
> Can be done but can't see any functional improvements. This seems ok to me.
Yeah, those are to reduce redundancy in code, not functional...... Otherwise the fix looks fine.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16674#discussion_r1417286814
More information about the client-libs-dev
mailing list