RFR: 8321176: [Screencast] make a second attempt on screencast failure [v2]
Anton Bobrov
duke at openjdk.org
Wed Dec 6 19:30:36 UTC 2023
On Wed, 6 Dec 2023 19:05:31 GMT, Phil Race <prr at openjdk.org> wrote:
>> Such change requires a [CSR](https://wiki.openjdk.org/display/csr) .
>> If we want to get this fix into JDK 22, we don't have time for CSR, since JDK 22 will be forked this Thursday.
>
> It is beyond that. It is an incompatible change. It will be rejected forever.
@prrace the related API already throw SecurityException if capture permission is not granted. moreover the API has been changed already in the pastr to accommodate that eg see
https://docs.oracle.com/javase/8/docs/api/java/awt/Robot.html#getPixelColor-int-int-
VS
https://docs.oracle.com/en/java/javase/21/docs/api/java.desktop/java/awt/Robot.html#getPixelColor(int,int)
and so it stands to reason that a similar solution can be found for this problem as well if there is a will to do so.
An exception seem to be the most logical solution here to me however it could be something different, like the approach you describe in JDK-8321475 (i cant comment there so commenting here instead). Either way, like i said, i firmly believe that the current API behavior is just plain wrong and potentially harmful.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16978#discussion_r1417881950
More information about the client-libs-dev
mailing list