RFR: 8320365: IPPPrintService.getAttributes() causes blanket re-initialisation [v2]

Phil Race prr at openjdk.org
Wed Dec 6 22:02:55 UTC 2023


> Whilst reviewing the fix for https://bugs.openjdk.org/browse/JDK-7001133 I realised that although the proposed
> changes there may help, the problem would be inconsequential except that if anything causes an app to
> call PrintService.getAttributes()  we will continually be re-initialising attributes, which causes IPPPrintService
> to keep creating new instances of CUPSPrinter which are then discarded and over-written.
> So update the implementation to only re-initialise the relevant attributes.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8320365

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16752/files
  - new: https://git.openjdk.org/jdk/pull/16752/files/22a601fd..26823aa9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16752&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16752&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/16752.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16752/head:pull/16752

PR: https://git.openjdk.org/jdk/pull/16752


More information about the client-libs-dev mailing list