RFR: 8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04 [v2]

Sergey Bylokhov serb at openjdk.org
Thu Dec 7 05:09:42 UTC 2023


On Thu, 7 Dec 2023 03:37:53 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> The root of this issue is the incorrect calculation of window decoration insets.
>> 
>> Previously we got non-zero window insets in the first PropertyNotify with [_NET_FRAME_EXTENTS](https://specifications.freedesktop.org/wm-spec/wm-spec-latest.html#idm45771211302000) atom, save them and never change them again.
>> 
>> This changed starting with Ubuntu 23.04:
>> Now we can get several such notifications with zero window insets, and only then the correct value.
>> 
>> Our code is not ready for this. It affects all our JDK. As a result, many tests fail on Ubuntu 23.04 and 23.10.
>> 
>> The solution is to change these insets on the fly, for now only for Mutter window manager. 
>> The guessInsets for it have also been updated.
>> 
>> 
>> This also means that some tests need some stabilization as they are not ready for such late arrival of window insets.
>> 
>> Testing looks good.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   copyright year updates

Did you check that these empty values are actually correct? I mean the empty insets are actually real insets of the window which later changed to the correct one? Maybe we should report this upstream?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16960#issuecomment-1844431644


More information about the client-libs-dev mailing list