RFR: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination [v7]
songpv-imt
duke at openjdk.org
Mon Dec 18 03:25:03 UTC 2023
On Fri, 15 Dec 2023 15:16:32 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> songpv-imt has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update InterJVMGetDropSuccessTest.java
>> Instead of using SYNC_LOCK to synchronize accessing the listener's fields, for better code transparency, we have placed the code that accesses the listener's fields from the main thread into the AWT Event Queue.
>
> test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.java line 273:
>
>> 271: robot.setAutoWaitForIdle(true);
>> 272: robot.mouseMove(sourcePoint.x, sourcePoint.y);
>> 273: Thread.sleep(50);
>
> Suggestion:
>
> robot.delay(50);
>
> Using `Robot.delay` is more common in tests, and it doesn't throw `InterruptedException`.
Thank you for your suggestions. The changes have been incorporated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16396#discussion_r1429444342
More information about the client-libs-dev
mailing list