RFR: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix [v2]

Andrey Turbanov aturbanov at openjdk.org
Thu Dec 21 21:27:39 UTC 2023


On Thu, 7 Dec 2023 09:17:05 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers, 
>> There was a typo for color conversion instead of dstColorSpace function srcColorSpace was used. Please review and let me know your suggestions if any. 
>> 
>> Renjith.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added test case

test/jdk/java/awt/color/NonICCFilterTest.java line 79:

> 77:                 raster.getWidth(), raster.getHeight(), Color.BLUE);
> 78:         g.setPaint(gp);
> 79:         g.fillRect(0,0,raster.getWidth(), raster.getHeight());

Suggestion:

        g.fillRect(0, 0, raster.getWidth(), raster.getHeight());

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16895#discussion_r1434524762


More information about the client-libs-dev mailing list