RFR: 8269806: Emoji rendering on Linux [v17]

[Nikita Gubarkov]

On Wed, 25 Jan 2023 18:42:24 GMT, Phil Race <prr at openjdk.org> wrote:

>> Nikita Gubarkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Skip tests if required font is absent
>
> src/java.desktop/macosx/classes/sun/font/CCharToGlyphMapper.java line 104:
> 
>> 102: 
>> 103:     public int charToVariationGlyph(int unicode, int variationSelector) {
>> 104:         if (variationSelector == 0) return charToGlyph(unicode);
> 
> We always use braces around the body, even for one line.

Fixed

> src/java.desktop/share/native/libfontmanager/freetypeScaler.c line 52:
> 
>> 50: // to build on older Linuxes, this is not a big problem,
>> 51: // as Linux uses bitmap emoji anyway.
>> 52: #if defined(_WIN32) || defined(__APPLE__)
> 
> Do we really have to disable coloured outlines because of what's available at build time ? Why can't we dynamically locate all the needed symbols at runtime ?

Fixed

-------------

PR: https://git.openjdk.org/jdk/pull/4798