RFR: 8081474: SwingWorker calls 'done' before the 'doInBackground' is finished [v10]

Alexey Ivanov aivanov at openjdk.org
Thu Feb 2 21:20:35 UTC 2023


On Thu, 2 Feb 2023 13:14:07 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> SwingWorker done() method [spec ](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L452) says "Executed on the Event Dispatch Thread after the doInBackground method is finished"
>> but there's no mechanism in place to honor that claim.
>> The [spec](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L289)
>> also says the state should be DONE after doInBackground() returns which is also not done.
>> 
>> Modified the code to honour the specification.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test update

test/jdk/javax/swing/SwingWorker/TestDoneBeforeDoInBackground.java line 43:

> 41:     public static void main(String[] args) throws InterruptedException {
> 42:         SwingWorker<String, String> worker =
> 43:             new SwingWorker<String, String>() {

Suggestion:

        SwingWorker<String, String> worker = new SwingWorker<>() {

Just noticed, it can be simplified.

-------------

PR: https://git.openjdk.org/jdk/pull/11940



More information about the client-libs-dev mailing list