RFR: 8292588: [macos] Multiscreen/MultiScreenLocationTest/MultiScreenLocationTest.java: Robot.mouseMove test failed on Screen #0 [v4]

Damon Nguyen dnguyen at openjdk.org
Fri Feb 3 22:42:54 UTC 2023


On Fri, 3 Feb 2023 20:20:24 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> test/jdk/java/awt/Multiscreen/MultiScreenLocationTest/MultiScreenLocationTest.java line 97:
>> 
>>> 95: //            if (!Util.testBoundsColor(bounds, color, 5, 1000, robot)) {
>>> 96: //                throw new RuntimeException(getErrorText("Robot.getPixelColor", i));
>>> 97: //            }
>> 
>> Why was this commented out? And if it's commented out, isn't it better to just be removed? It still seems to pass with it included. 
>> 
>> I tested with the newest changes. It passes on my local machine running macOS Monterey 12.3.1 using dual monitors. The test does create a yellow frame on both monitors and the color check passes in the test. I ran the test 5 times locally without any failures.
>
> @DamonGuy can you double check that this portion of the test also passes on your machine?

I checked again with `testBoundsColor` conditional commented and uncommented, and both passed with a dual monitor setup on macOS Monterey 12.3.1

-------------

PR: https://git.openjdk.org/jdk/pull/10363



More information about the client-libs-dev mailing list