RFR: JDK-7154070: in SwingSet2, switching between LaFs it's easy to lose JTable dividers [v4]

Prasanta Sadhukhan psadhukhan at openjdk.org
Mon Feb 6 08:50:53 UTC 2023


On Mon, 6 Feb 2023 05:56:49 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   test fix
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTableUI.java line 234:
> 
>> 232:         }
>> 233:         SynthContext context = getContext(table, ENABLED);
>> 234:         if (showHorizLines) {
> 
> I think we should make this condition tighter to avoid unnecessary repaints like in GTK LAF.
> Like only when current property is false and we expect it to be true and then only call setShowHorizontal/VerticalLines()

I am not sure what you meant..
uninstallDefaults will be called only once during L&F transition from Nimbus to other L&F and
 it will set horizontal and vertical lines only if it was set in other L&F before Nimbus L&F takes effect..
If other L&F did not have those set, it will not call setShowHorizontal/VerticalLines()

-------------

PR: https://git.openjdk.org/jdk/pull/12385



More information about the client-libs-dev mailing list