RFR: 6513512: MetalLookAndFeel.initClassDefaults does not install an entry for MetalMenuBarUI [v4]

Prasanta Sadhukhan psadhukhan at openjdk.org
Mon Feb 6 09:26:52 UTC 2023


On Fri, 3 Feb 2023 18:09:06 GMT, Phil Race <prr at openjdk.org> wrote:

> These words - "This class is only appropriate for Ocean. The spec needs to be updated to mention this."
> 
> WHY can no other Theme use it ? Is there a reason ? I think the comment does not have enough backing explanation to be simply followed blindly.

I think you are right.
As per MetalMenuBarUI spec also, it is mentioned "Metal implementation of <code>MenuBarUI</code>. This class is responsible for providing the metal look and feel for <code>JMenuBar</code>s."

ie it is mentioned for Metal L&F and not for a particular theme

so I have reinstated my 1st iteration of the PR..
Please review...

All clientlibs tests are ok, link in JBS

-------------

PR: https://git.openjdk.org/jdk/pull/11646



More information about the client-libs-dev mailing list