RFR: 8292588: [macos] Multiscreen/MultiScreenLocationTest/MultiScreenLocationTest.java: Robot.mouseMove test failed on Screen #0 [v5]

[Alexey Ivanov]

On Fri, 3 Feb 2023 20:24:16 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Fixed test bug where mouse location was being calculated before robot mouseMove operation was complete
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   uncommented portion of test

test/jdk/java/awt/Multiscreen/MultiScreenLocationTest/MultiScreenLocationTest.java line 115:

> 113:                             String.format("0x%08X",image.getRGB(image.getWidth() - 1, image.getHeight() - 1)));
> 114:                     System.out.println("Robot.createScreenCapture Top Left Actual: " +
> 115:                             String.format("0x%08X",image.getRGB(0, image.getHeight() - 1)));

There's no space after the comma, after the format string. Yet there are spaces in `getRGB`, probably because they're copied from the `if`-condition.

test/jdk/java/awt/regtesthelpers/Util.java line 178:

> 176:             }
> 177:             System.out.println("Robot.getPixelColor Expected: " + color);
> 178:             System.out.println("Robot.getPixelColor Actual: " + screen);

This may be not the best solution. If the method is used on a large image / rectangle (it's called from `testBoundsColor`), the output could be flooded with messages. Eventually, it may slow down test execution. At the same time, there's no other way to provide debugging info.

-------------

PR: https://git.openjdk.org/jdk/pull/10363