RFR: 6753661: JFileChooser font not reset after Look & Feel change [v4]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu Feb 9 02:59:11 UTC 2023


On Wed, 8 Feb 2023 11:44:28 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   jcheck fix
>
> test/jdk/javax/swing/JFileChooser/JFileChooserFontReset.java line 53:
> 
>> 51:             SwingUtilities.invokeAndWait(() -> setLookAndFeel(laf));
>> 52:             JFileChooser fc = new JFileChooser();
>> 53:             Font origFont = fc.getFont();
> 
> This is really inconsistent: you set L&F on EDT but you create `JFileChooser` on main thread. You should either do everything on main thread or, preferably, move all the test code onto EDT.

ok

-------------

PR: https://git.openjdk.org/jdk/pull/12180



More information about the client-libs-dev mailing list