RFR: 8081474: SwingWorker calls 'done' before the 'doInBackground' is finished [v15]

[Prasanta Sadhukhan]

On Fri, 10 Feb 2023 14:31:59 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix and test updated
>>  - Fix and test updated
>
> test/jdk/javax/swing/SwingWorker/TestDoneBeforeDoInBackground.java line 29:
> 
>> 27:  *           before the 'doInBackground' is finished
>> 28:  * @run main TestDoneBeforeDoInBackground
>> 29:  */
> 
> May I ask you to move the jtreg tags to the class declaration, please? When the file is opened in the IDE, they're not collapsed (together with the license block above) and easily accessible.

Not sure on this..it seems it is same for other tests also..

> test/jdk/javax/swing/SwingWorker/TestDoneBeforeDoInBackground.java line 130:
> 
>> 128:               worker.getState() != SwingWorker.StateValue.DONE) {
>> 129:             throw new RuntimeException("doInBackground is finished " +
>> 130:                                        " but State is not DONE");
> 
> Suggestion:
> 
>                                        "but the State is not DONE");
> 
> Two consecutive spaces in an error message are redundant, one is enough.
> 
> The article seems missing?

Modified except condition kept separate for distinct failure message

-------------

PR: https://git.openjdk.org/jdk/pull/11940