RFR: 8299592: Fix and reenable warnings in java.desktop native code compilation [v2]

[SWinxy]

On Fri, 20 Jan 2023 12:01:06 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Please review this patch that fixes and re-enables a few warnings in libawt compilation.
>> 
>> Verified that debug and release builds finish successfully on Win, Mac and Linux. Also verified that client libs tests still pass.
>
> Daniel Jeliński has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits:
> 
>  - Merge remote-tracking branch 'origin' into awt-warning-cleanup
>  - Copyright
>  - snprintf
>  - cl analyze
>  - Fix non-debug warning
>  - Restore suppressions
>  - Fix warnings
>  - WIP: reenable awt warnings
>  - Fix warnings

These changes look fine to me as well. Built and ran a couple dozen tests. `D3DBlitLoops.cpp` looks to have had a hidden bug that is now fixed with this patch. Granted, I am not to be trusted with native code.

-------------

Marked as reviewed by SWinxy at github.com (no known OpenJDK username).

PR: https://git.openjdk.org/jdk/pull/11841