RFR: 6753661: JFileChooser font not reset after Look & Feel change [v6]

Prasanta Sadhukhan psadhukhan at openjdk.org
Mon Feb 13 09:22:35 UTC 2023


On Fri, 10 Feb 2023 17:08:34 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I dont think it's redundant..There's a || check in between
>> 
>> If `curFont `is not null and `origFont `is null, then 1st condition `curFont != null && !curFont.equals(origFont)` is satisfied and it will throw exception
>> 
>> If `origFont `is not null and `curFont `is null, then 1st condition `curFont != null && !curFont.equals(origFont)` is not satisfied and 2nd condition `origFont != null && !origFont.equals(curFont)` is satisfied and it will throw exception. If we remove origFont.equals(curFont) check, it will not check the fix..
>
> `curFont != origFont && (curFont != null && !curFont.equals(origFont))`
> 
> The first part catches the case where both are null.

ok..modified but I guess mine was not "incorrect" either..

-------------

PR: https://git.openjdk.org/jdk/pull/12180



More information about the client-libs-dev mailing list