RFR: 7093691: Nimbus LAF: disabled JComboBox using renderer has bad font color [v4]

Damon Nguyen dnguyen at openjdk.org
Tue Feb 14 19:11:20 UTC 2023


On Thu, 9 Feb 2023 03:21:07 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> > > > I created an automated test, but for some L&F's (such as Nimbus), an enabled vs disabled ComboBox differs in more than just the text color. The background, border, and button color may change as well
> > > 
> > > 
> > > Then can we not compare the comboBox without DLCR with comboBox with DLCR when both are disabled...both should be same as per your screenshot
> > 
> > 
> > A comboBox with DLCR is slightly smaller than one without DLCR (138x25 vs 140x25). If I force the same dimensions with setSize, the RGB values are slightly off. If these comboBoxes are supposed to exactly match in dimensions, they currently don't, and this is due to what would be a separate bug if so.
> 
> maybe you can try to compare the mid scanline rather than the whole rectangle

Replaced the original test with an automated version using a mid scanline. I can't scan across the whole midline because of the width difference, so I adjusted the testing method slightly to accommodate for this.

-------------

PR: https://git.openjdk.org/jdk/pull/12390



More information about the client-libs-dev mailing list