RFR: 8299522: Incorrect size of Approve button in custom JFileChooser [v12]

Damon Nguyen dnguyen at openjdk.org
Fri Feb 17 22:53:32 UTC 2023


On Tue, 17 Jan 2023 05:37:38 GMT, Tejesh R <tr at openjdk.org> wrote:

>> FileChooser Open/Approve button size is shown incorrectly when no Approve button text is set in `CUSTOM_DIALOG` type. Reason being that no default Approve Button text is returned during Dialog Type Property change. Since `null` is returned as Button string the Button size is incorrectly shown. The fix here addresses the issue by adding a default Approve Button Text when no text is set explicitly in case of `CUSTOM_DIALOG` type.
>> Automated test is attached which has been tested with multiple test runs.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unused imports

Changes still LGTM. I re-synced my repos and tried with and without your changes. The previous comments seem to be addressed as well. Just the copyright year still as previously commented.

-------------

Marked as reviewed by dnguyen (Author).

PR: https://git.openjdk.org/jdk/pull/11901



More information about the client-libs-dev mailing list