RFR: 8302558: Editable JComboBox 's popup blocks user from seeing characters in Acq look and feel [v2]

[Damon Nguyen]

On Mon, 27 Feb 2023 19:19:40 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Propagate exceptions. Move methods to EDT.
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxPopup.java line 189:
> 
>> 187: 
>> 188:         int popupBoundsY = comboBox.getBounds().height;
>> 189:         if (comboBox.isEditable() && comboBox.getBorder() != null) {
> 
> Does it not affect a non-editable combo box with with a border that has large insets?

In testing, it does also affect this case. In the normal use cases in testing, this editable Aqua comboBox with a TitledBorder seemed to be the only problematic one, but with custom large borders, this seems to also be an issue.

I recently discussed with @lawrence-andrew and learned that in the setBorder doc for JComponent, UI components are not fully supported with borders. It is instead recommended to place the component in a JPanel. I think this is one of those cases, but the fix in this PR fixes the found issue for the case of an editable Aqua comboBox with a border.

If you could give insights on this Lawrence, that'd be appreciated as well.

-------------

PR: https://git.openjdk.org/jdk/pull/12750