RFR: 8299553: Make ScaledEtchedBorderTest.java comprehensive

[Alexey Ivanov]

On Tue, 3 Jan 2023 23:06:16 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> The `ScaledEtchedBorderTest.java` test ([JDK-8279614](https://bugs.openjdk.org/browse/JDK-8279614)) verifies that the thickness of lines of `EtchedBorder` is consistent. The component inside had the same background color as the frame. Yet if there's another component the background of which is different, that background could be seen.
>> 
>> The updated test covers the scenario reported in [JDK-8294921](https://bugs.openjdk.org/browse/JDK-8294921).
>> 
>> The bug itself is fixed by refactoring [JDK-8294680](https://bugs.openjdk.org/browse/JDK-8294680) the border rendering code which uses a more precise coordinate calculation, see #11571. Thus, I contribute the test under a separate bugid.
>> 
>> I also modified `ScaledLineBorderTest.java` so that the location of the child panels is saved when they're created as done in `ScaledTextFieldBorderTest.java` in #11498. I removed the unused `Component` import after this modification from both tests.
>
> test/jdk/javax/swing/border/EtchedBorder/ScaledEtchedBorderTest.java line 239:
> 
>> 237:     }
>> 238: 
>> 239:     private enum State {
> 
> enum declaration can be moved before its first usage (before `checkBorder()`)

I agree here, the `State` enum is declared before `checkBorder` in `ScaledTextFieldBorderTest.java`, yet it's after the method in both `ScaledLineBorderTest.java` and `ScaledEtchedBorderTest.java`.

-------------

PR: https://git.openjdk.org/jdk/pull/11836