RFR: 8218474: JComboBox display issue with GTKLookAndFeel [v2]

Abhishek Kumar abhiscxk at openjdk.org
Thu Jan 5 05:51:52 UTC 2023


On Tue, 3 Jan 2023 01:21:07 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Review comment update
>>  - Merge
>>  - Merge
>>  - Combobox componnet rendering fix
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java line 372:
> 
>> 370:                             arrowButton.getPreferredSize().width;
>> 371:         //adjust the size based on the button width
>> 372:         size.height += insets.top + insets.bottom + arrowInsets.top
> 
> Are you sure that the arrow insets should be applied on top of the component's insets, probably the maximum of both should be selected?

@mrserb Are you ok with the fix or do you want anything to add?

-------------

PR: https://git.openjdk.org/jdk/pull/11555



More information about the client-libs-dev mailing list