RFR: 8298240: Replace the usage of ImageLayoutException by the CMMException [v2]
Phil Race
prr at openjdk.org
Thu Jan 5 20:16:53 UTC 2023
On Fri, 30 Dec 2022 07:22:21 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> ImageLayoutException is used to report any issues with image layout calculation. But since we cannot throw the unspecified exception to the application, all usages of ImageLayoutException are wrapped by the CMMException. And now if such CMMException occurs we have lost at what point the initial exception was raised.
>>
>> We can pass some additional data around, but it looks like we can just delete the ImageLayoutException and use CMMException instead.
>>
>> Additionally:
>> * The `public` keyword is removed in a few places if not needed.
>> * The PT_XX flags are updated to make it clearly visible how they are related.
>
> Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Merge remote-tracking branch 'upstream/master' into delete_imagelayout
> - Simplify rge PT_XXX and replace public
> - delete ImageLayoutException
Seems reasonable to me.
-------------
Marked as reviewed by prr (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11552
More information about the client-libs-dev
mailing list