RFR: 8299425: "LCMSImageLayout.isIntPacked" flag can be deleted

Phil Race prr at openjdk.org
Thu Jan 5 22:14:49 UTC 2023


On Sat, 31 Dec 2022 03:22:20 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> After this change we will set correct pixel formatter when we initially create it, instead of updating the pixel formatter in native based on additional "isIntPacked" flag.
> 
> FYI: The fix for https://bugs.openjdk.org/browse/JDK-7124245 added the "isIntPacked" flag to mark the non-byte pixels layouts(like TYPE_INT_RGB).
> * This flag is passed around even if it is not used by the pixel layout
> * It may cause unnecessary creation of new transform if one type is "rgb && isIntPacked=true" and another one is "bgr && isIntPacked=false", but the actual data is the same
> see: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/2cf07dbdee64

Marked as reviewed by prr (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/11806



More information about the client-libs-dev mailing list