RFR: 7131166: SynthListUI / SynthInternalFrameTitlePane updateStyle() ignores method argument

[Prasanta Sadhukhan]

On Fri, 6 Jan 2023 04:42:37 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> It seems Synth has two cases of updateStyle() where its argument is not passed to the getContext() call. It seems to be an oversight as in other Synth classes, the component argument passed to updateStyle is being passed to getContext().
> 
> CI tests are ok with this change and there is no new regeression with CI tests run in NimbusL&F by default..

I didn't see any new issues with the CI tests run with and without SynthL&F, nor did I see any issue in SwingSet2..I could not see how else it can be tested..
I did not try this late jdk20 time-frame and trying this now beginning of jdk21 so that if there are any issues found, we can fix or revert before jdk21 release.

Also, looking at other Synth classes, it seems to be the way to go to maintain consistency

https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthButtonUI.java#L86
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthColorChooserUI.java#L91
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java#L154
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthDesktopIconUI.java#L148
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthDesktopPaneUI.java#L143
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthEditorPaneUI.java#L133
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthLabelUI.java#L75
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthMenuBarUI.java#L83
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthMenuUI.java#L83
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTableUI.java#L143

etc

-------------

PR: https://git.openjdk.org/jdk/pull/11875