RFR: 7131166: SynthListUI / SynthInternalFrameTitlePane updateStyle() ignores method argument

SWinxy duke at openjdk.org
Sat Jan 7 01:41:50 UTC 2023


On Fri, 6 Jan 2023 04:42:37 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> It seems Synth has two cases of updateStyle() where its argument is not passed to the getContext() call. It seems to be an oversight as in other Synth classes, the component argument passed to updateStyle is being passed to getContext().
> 
> CI tests are ok with this change and there is no new regeression with CI tests run in NimbusL&F by default..

I'm seeing a slightly larger problem of inconsistencies as to what is passed into the `updateStyle` methods. `SynthInternalFrameTitlePane` passes `this` to `getContext`, while nothing else does. `SynthInternalFrameTitlePane` and `SynthComboBoxUI` don't pass in the event source in their `propertyChange` methods unlike everything else. `SynthTextFieldUI` and `SynthTextAreaUI` passes in a call to `getComponent()`, while e.g. `SynthTableHeaderUI` passes in the protected field. Inconsistent!

I don't think this change will do anything bad though.

-------------

PR: https://git.openjdk.org/jdk/pull/11875



More information about the client-libs-dev mailing list